fix: update HMDB IDs to version 4 #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update HMDB IDs to version 4 format by inserting double zero
orsiliska
suggested changes
Nov 18, 2022
There was a problem hiding this comment.
Thank you for the quick response!
I looked over the updated IDs. They are mostly correct, with the exception of 23 IDs.
I'm attaching a table of the incorrect IDs and their correct versions.
In short:
- 5 IDs have now been revoked by HMDB as the records weren't reliable.
- 9 IDs have been replaced by new ones. The updated version of these IDs can still be found in HMDB as secondary IDs.
- 8 IDs were updated when they didn't need to be.
- 1 ID, that of D-aspartate originally contained a typo, but didn't need to be updated otherwise.
All other updated IDs are currently primary IDs in HMDB, and should be kept kept in the model in their updated form.
hmdbs_to_fix.txt
|
@orsiliska excellent! The 23 IDs reported in above table had been corrected and are ready for your inspection. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
I hereby confirm that I have:
developas a target branch